Deprecate ProductArray - #368
Merged
Merged
Conversation
kellertuer
approved these changes
May 27, 2021
kellertuer
left a comment
kellertuer
left a comment
Member
There was a problem hiding this comment.
Looks good to me, though I was surprised that there is no @deprecate for types.
Member
|
Something in the packages seems to have changes, see also the latest merge/commit on master. Suddenly 5 tests are failing and I haven't understood why. |
Member
Author
|
Maybe JuliaManifolds/ManifoldsBase.jl#73 added some ambiguities? I'm not sure. |
Member
|
Maybe it did, yes. |
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 76 76
Lines 5915 5915
=======================================
Hits 5792 5792
Misses 123 123
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #366 (comment) .